fix: revert composition root #6492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method index.ts: createServices 🔥
Comment on lines
+299
to
+319
| const clientFeatureToggleReadModel = db | ||
| ? new ClientFeatureToggleReadModel(db, config.eventBus) | ||
| : new FakeClientFeatureToggleReadModel(); | ||
| const globalFrontendApiCache = new GlobalFrontendApiCache( | ||
| config, | ||
| segmentReadModel, | ||
| clientFeatureToggleReadModel, | ||
| configurationRevisionService, | ||
| ); | ||
|
|
||
| const proxyService = new ProxyService( | ||
| config, | ||
| stores, | ||
| { | ||
| featureToggleServiceV2, | ||
| clientMetricsServiceV2, | ||
| settingService, | ||
| configurationRevisionService, | ||
| }, | ||
| globalFrontendApiCache, | ||
| ); |
There was a problem hiding this comment.
❌ Getting worse: Complex Method
createServices already has high cyclomatic complexity, and now it increases in Lines of Code from 250 to 267
Why does this problem occur?
This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring. Read more.
To ignore this warning click here.
sjaanus
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Closes #
Important files
Discussion points