fix: icon imports #6499
fix: icon imports #6499
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules than 99% of the historic high-risk change sets. The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules than 99% of the historic high-risk change sets. The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
| import FlagRounded from '@mui/icons-material/FlagRounded'; | ||
| import Report from '@mui/icons-material/Report'; | ||
| import Timeline from '@mui/icons-material/Timeline'; | ||
| import { SvgIconComponent } from '@mui/icons-material'; |
There was a problem hiding this comment.
This is a type and does not seem to affect the module count
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules than 99% of the historic high-risk change sets. The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
Based on this article: https://mui.com/material-ui/guides/minimizing-bundle-size/ importing from
'@mui/icons-material'instead of specifying the actual path to the icon likeimport Delete from '@mui/icons-material/Delete';can be up to six time slower. This change changes all named imports in Unleash referencing the@mui/icons-materialto default imports.This reduced the amount of modules we had to process when building the frontend from 15206 to 4746
Before:
After:
Build time locally decreased by around 50%
Before:
After:
