refactor: rename proxy to frontend api in openapi schemas #6511
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method metrics.ts: MetricsMonitor.startMonitoring
- Code Duplication frontend-api-service.ts
✅ Improving Code Health:
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method metrics.ts: MetricsMonitor.startMonitoring
- Code Duplication frontend-api-service.ts
✅ Improving Code Health:
| @@ -168,8 +168,7 @@ export class FrontendApiService { | |||
| if (!newClient) { | |||
| newClient = this.createNewClientForFrontendApiToken(token); | |||
| this.newClients.set(token.secret, newClient); | |||
| // TODO: do we need this twice? | |||
| // this.config.eventBus.emit(PROXY_REPOSITORY_CREATED); | |||
| this.config.eventBus.emit(FRONTEND_API_REPOSITORY_CREATED); | |||
There was a problem hiding this comment.
track frontend api repositories same as proxy repositories
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method metrics.ts: MetricsMonitor.startMonitoring
- Code Duplication frontend-api-service.ts
✅ Improving Code Health:
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method metrics.ts: MetricsMonitor.startMonitoring
- Code Duplication frontend-api-service.ts
✅ Improving Code Health:
About the changes
Important files
Discussion points