Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a script that validates that we don't use prohibited mui material-icons import #6516

Merged
merged 6 commits into from
Mar 12, 2024

Conversation

FredrikOseberg
Copy link
Contributor

This PR adds a check that should fail the build if we use disallowed imports from @mui/icons-material

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 11:31am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 11:31am

@FredrikOseberg FredrikOseberg changed the title fix: add bash script chore: add a script that validates that we don't use prohibited mui material-icons import Mar 12, 2024
Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;)

import { BannerDialog } from 'component/banners/Banner/BannerDialog/BannerDialog';
import { Visibility } from '@mui/icons-material';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this import seems wrong

@FredrikOseberg FredrikOseberg merged commit 9c29461 into main Mar 12, 2024
14 checks passed
@FredrikOseberg FredrikOseberg deleted the fix/icon-imports-check branch March 12, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants