Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid HTML and react errors in insights pages #6593

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Mar 18, 2024

This PR fixes these errors (that were showing up in the dev console) in the insights pages:

  • nesting a div within a p in the count header (flags, environments, apps); instead flip the relationship and nest the p within the div
  • missing keys in mapped components
  • passing a boolean "scrolled" value to the underlying component (a div) is invalid: instead, make it so that that prop is not passed

The only one of these that could have a visual impact is the first one (p>div -> div>p), but it appears to be the same to me.

Here's before the change:
image

And here's after:
image

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 2:20pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 2:20pm

@thomasheartman
Copy link
Contributor Author

Err, minor update: found that I might've attacked the wrong boolean prop? I'll check

@thomasheartman
Copy link
Contributor Author

Nope! Just solved it in the wrong way.

@thomasheartman thomasheartman merged commit c2015c6 into main Mar 18, 2024
13 checks passed
@thomasheartman thomasheartman deleted the fix/insights-invalid-html branch March 18, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant