Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configurable event for banner goto action #6603

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Mar 19, 2024

We added banner to get attention of customer, but we are not tracking its usage.
Added a way to track the goto action button.

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 10:06am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 10:06am

<li
key={application}
onClick={bannerClicked}
onKeyDown={bannerClicked}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for keyboard navigation

@sjaanus sjaanus changed the title feat: add configurable event for banner go to action feat: add configurable event for banner goto action Mar 19, 2024
Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@sjaanus sjaanus merged commit ec7bb2d into main Mar 19, 2024
13 checks passed
@sjaanus sjaanus deleted the banner-goto-actin branch March 19, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants