chore: orval with project insights #6621
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
| @@ -142,7 +142,11 @@ export const IntegrationForm: VFC<IntegrationFormProps> = ({ | |||
| : event.target.value; | |||
| setFormValues( | |||
| produce((draft) => { | |||
| draft.parameters[param] = value; | |||
| if (value === undefined) { | |||
There was a problem hiding this comment.
Solving:
src/component/integrations/IntegrationForm/IntegrationForm.tsx(145,21): error TS2322: Type 'string | undefined' is not assignable to type 'WritableDraft<{}>'.
Type 'undefined' is not assignable to type 'WritableDraft<{}>'.
There was a problem hiding this comment.
code that was added here: #2547 is giving us TS errors now
There was a problem hiding this comment.
@nunogois can you take a look if my change is safe? I tested it locally and it looks like parameter removal in addon still works fine and now TS is happy too
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
About the changes
Closes #
Important files
Discussion points