-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adapted IUser to our DB schema #6627
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
frontend/src/interfaces/user.ts
Outdated
export const AccountTypes = ['User', 'Service Account'] as const; | ||
type AccountType = (typeof AccountTypes)[number]; | ||
|
||
export interface IUser { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be replaced with the server type from @server/types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This didn't work well because the frontend interface has other fields and it was not easy to fix
About the changes
Our schema allows us to have null username or email. With this change at least we'll get a compiler warning when using either of these properties