-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create new flag to hide insights ui (#6638) #6653
Conversation
Creates a new flag to control the executive dashboard ui Closes # [1-2208](https://linear.app/unleash/issue/1-2208/create-separate-ui-flag-decoupled-from-the-backend-flag) --------- Signed-off-by: andreas-unleash <andreas@getunleash.ai> (cherry picked from commit 84707e2) Signed-off-by: andreas-unleash <andreas@getunleash.ai>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
@@ -66,8 +66,8 @@ export const routes: IRoute[] = [ | |||
title: 'Insights', | |||
component: ExecutiveDashboard, | |||
type: 'protected', | |||
menu: { mobile: true, advanced: true }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing advanced: true
here? What does that mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Advanced is the dropdown menu Configuration
. So it was on the nav bar but also the dropdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, so it was a duplicate, and it's not supposed to be?
Creates a new flag to control the executive dashboard ui
Closes #
1-2208
(cherry picked from commit 84707e2)
About the changes
Closes #
Important files
Discussion points