fix: add forwardRef to ProjectSelect component #6674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we wrap this in a tooltip in the Playground, we need to forward the ref to the underlying component. This follows the steps outlined in https://mui.com/material-ui/guides/composition/#caveat-with-refs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Improving Code Health:
- Complex Method ProjectSelect.tsx: ProjectSelect:VFC<IProjectSelectProps>
Comment on lines
-33
to
-40
| export const ProjectSelect: VFC<IProjectSelectProps> = ({ | ||
| selectedProjects, | ||
| onChange, | ||
| dataTestId, | ||
| sx, | ||
| disabled, | ||
| }) => { | ||
| const { projects: availableProjects } = useProjects(); |
There was a problem hiding this comment.
✅ No longer an issue: Complex Method
ProjectSelect:VFC<IProjectSelectProps> is no longer above the threshold for cyclomatic complexity
kwasniew
approved these changes
Mar 25, 2024
thomasheartman
deleted the
fix/playground-project-selection-tooltip-not-working
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the tooltip for project selection in the playground work properly again. Right now, it doesn't work due to an error in react refs.
Because we wrap this in a tooltip in the Playground, we need to forward the ref to the underlying component.
This follows the steps outlined in https://mui.com/material-ui/guides/composition/#caveat-with-refs