chore: [Gitar] Cleaning up stale feature flag: sdkReporting with value true #6717
Conversation
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
gitar-bot
bot
force-pushed
the
gitar_gitar__sdkReporting_true
branch
from
3a2d173
to
43c80fe
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: No code is modified, but the change set deletes (33) lines of code, which is an unusal pattern in this repo.
View detailed results in CodeScene
✅ Improving Code Health:
- Large Method Application.tsx: Application
| @@ -70,7 +68,6 @@ const StyledTab = styled(Tab)(({ theme }) => ({ | |||
| })); | |||
|
|
|||
| export const Application = () => { | |||
| const useOldApplicationScreen = !useUiFlag('sdkReporting'); | |||
There was a problem hiding this comment.
✅ Getting better: Large Method
Application decreases from 139 to 135 lines of code, threshold = 120
Why does this problem occur?
Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function. Read more.
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Improving Code Health:
- Large Method Application.tsx: Application
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Improving Code Health:
- Large Method Application.tsx: Application
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Improving Code Health:
- Large Method Application.tsx: Application
sjaanus
changed the title
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Improving Code Health:
- Large Method Application.tsx: Application
Feature Flag Cleanup
Trigger
#6559 (comment)
Bot Commands
@gitar-bot cleanup stale_flag=valuewill cleanup a stale feature flag. Replacestale_flagwith the name of the stale feature flag andvaluewith eithertrueorfalse.