Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep parent selection in edit dependency dialogue #6727

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Mar 28, 2024

About the changes

Before: remove dependency option always selected by default
Screenshot 2024-03-28 at 10 29 51

After: if there's existing parent dependency it gets auto-selected by default
Screenshot 2024-03-28 at 10 29 42

Important files

Discussion points

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 10:11am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 10:11am

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene

@kwasniew kwasniew changed the title feat: keep parent selection in edit dependency modal feat: keep parent selection in edit dependency dialogue Mar 28, 2024
Copy link
Contributor

@sjaanus sjaanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I thought this was bug.

@kwasniew kwasniew merged commit 99935fe into main Mar 28, 2024
12 of 15 checks passed
@kwasniew kwasniew deleted the maintain-previous-parent-selection branch March 28, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants