feat: collect prometheus data about archived features #6728
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method metrics.ts: MetricsMonitor.startMonitoring
- Large Method instance-stats-service.ts: InstanceStatsService.getStats
| @@ -215,6 +222,7 @@ export class InstanceStatsService { | |||
| const versionInfo = await this.versionService.getVersionInfo(); | |||
| const [ | |||
| featureToggles, | |||
| archivedFeatureToggles, | |||
There was a problem hiding this comment.
❌ Getting worse: Large Method
InstanceStatsService.getStats increases from 78 to 81 lines of code, threshold = 70
Why does this problem occur?
Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function. Read more.
To ignore this warning click here.
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method metrics.ts: MetricsMonitor.startMonitoring
- Large Method instance-stats-service.ts: InstanceStatsService.getStats
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method metrics.ts: MetricsMonitor.startMonitoring
- Large Method instance-stats-service.ts: InstanceStatsService.getStats
|
|
||
| const featureTogglesArchivedTotal = createGauge({ | ||
| name: 'feature_toggles_archived_total', | ||
| help: 'Number of archived feature toggles', | ||
| }); |
There was a problem hiding this comment.
❌ Getting worse: Complex Method
MetricsMonitor.startMonitoring already has high cyclomatic complexity, and now it increases in Lines of Code from 516 to 522
Why does this problem occur?
This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring. Read more.
To ignore this warning click here.
No description provided.