Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: semver constraint context fields improvements #6730

Merged

Conversation

andreas-unleash
Copy link
Contributor

Increases the label width to make the whole box selectable
Adds a small gap to match the style

Closes # 1-2233

before:
Screenshot 2024-03-28 at 14 19 39

after:
Screenshot 2024-03-28 at 14 19 16

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 6:15am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2024 6:15am

))}
</RadioGroup>
</FormControl>
<div style={{ display: 'flex' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of the extra div?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should encapsulate the fieldset. Intention was to limit the height when a lot of values so that it has a scroll. This was an incomplete version

Signed-off-by: andreas-unleash <andreas@getunleash.ai>
@andreas-unleash andreas-unleash merged commit e797018 into main Apr 2, 2024
13 checks passed
@andreas-unleash andreas-unleash deleted the chore/semver-contraint-context-fields-improvements branch April 2, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants