feat: disabled feature dependency #6731
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 4 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method DependencyRow.tsx: DependencyRow:FC<{feature:IFeatureToggle}>
- Excess Number of Function Arguments AddDependencyDialogue.tsx: useManageDependency
- Complex Method AddDependencyDialogue.tsx: AddDependencyDialogue
- Complex Method AddDependencyDialogue.tsx: useManageDependency
| }; | ||
|
|
||
| export const AddDependencyDialogue = ({ | ||
| project, | ||
| featureId, | ||
| parentFeatureId, | ||
| parentFeatureValue, |
There was a problem hiding this comment.
❌ New issue: Complex Method
AddDependencyDialogue has a cyclomatic complexity of 10, threshold = 10
Why does this problem occur?
This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring. Read more.
To ignore this warning click here.
| const useManageDependency = ( | ||
| project: string, | ||
| featureId: string, | ||
| parent: string, | ||
| parentValue: ParentValue, |
There was a problem hiding this comment.
❌ New issue: Complex Method
useManageDependency has a cyclomatic complexity of 10, threshold = 10
Why does this problem occur?
This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring. Read more.
To ignore this warning click here.
| const useManageDependency = ( | ||
| project: string, | ||
| featureId: string, | ||
| parent: string, | ||
| parentValue: ParentValue, |
There was a problem hiding this comment.
❌ New issue: Excess Number of Function Arguments
useManageDependency has 5 arguments, threshold = 4
Why does this problem occur?
This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments. Read more.
To ignore this warning click here.
| <ConditionallyRender | ||
| condition={ | ||
| hasParentDependency && !feature.dependencies[0]?.enabled | ||
| } | ||
| show={ | ||
| <FlexRow> | ||
| <StyledDetail> | ||
| <StyledLabel>Dependency value:</StyledLabel> | ||
| <span> | ||
| {feature.dependencies[0]?.enabled | ||
| ? 'enabled' | ||
| : 'disabled'} | ||
| </span> | ||
| </StyledDetail> | ||
| </FlexRow> | ||
| } | ||
| /> |
There was a problem hiding this comment.
❌ New issue: Complex Method
DependencyRow:FC<{feature:IFeatureToggle}> has a cyclomatic complexity of 13, threshold = 10
Why does this problem occur?
This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring. Read more.
To ignore this warning click here.
| <ConditionallyRender | ||
| condition={showDependencyDialogue} | ||
| show={ | ||
| <LazyOptions | ||
| project={project} | ||
| featureId={featureId} | ||
| parent={parent} | ||
| onSelect={setParent} | ||
| onSelect={(status) => { | ||
| setParentValue({ status: 'enabled' }); |
There was a problem hiding this comment.
Maybe it should not reset the bottom configuration.
There was a problem hiding this comment.
I don't have a strong opinion here so let's gather feedback. I started w/o reset and it felt weird but it's just one opinion. For now it's hidden behind a flag anyway.
About the changes
Feature dependency on a disabled feature (e.g. killswitch)
Important files
Screen.Recording.2024-03-28.at.13.47.46.mov
Details:
Discussion points