Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert archived column for backwards migration compatibility #6737

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Mar 29, 2024

About the changes

When downgrading to 5.10 we had one query impacted because of the missing legacy archived column (used in getFeatureTypeCounts). Bringing it back so that we keep our rule of being backwards compat for 2 versions (from our db changes ADR).

It reverts this change: #6431

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Mar 29, 2024 7:03am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Mar 29, 2024 7:03am

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene

Copy link
Member

@ivarconr ivarconr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

@kwasniew kwasniew merged commit 11f4155 into main Mar 29, 2024
10 checks passed
@kwasniew kwasniew deleted the revert-archived-column-for-backwards-compatibility branch March 29, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants