chore: stop using deprecated method #6764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
nunogois
reviewed
Apr 3, 2024
| const userDetails = eventService.getUserDetails(adminToken); | ||
| expect(userDetails.createdBy).toBe('admin-token-username'); | ||
| expect(userDetails.createdByUserId).toBe(ADMIN_TOKEN_USER.id); | ||
| }); |
There was a problem hiding this comment.
I guess this is no longer relevant, which is why it's getting deleted.
There was a problem hiding this comment.
Indeed, this was only testing getUserDetails that was only added to serve these new methods. There was no other test (which is sad).
nunogois
approved these changes
Apr 3, 2024
gastonfournier
deleted the
2-2044-we-need-to-get-rid-of-createuserevent-from-event-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storeUserEventfrom event-service was deprecated. We stop using it and remove the method completely