fix: tabs alignment #6768
fix: tabs alignment #6768
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| @@ -272,20 +272,23 @@ export const Project = () => { | |||
| tab.isEnterprise ? 'end' : undefined | |||
| } | |||
| icon={ | |||
| <span> | |||
There was a problem hiding this comment.
this span was breaking alignment and it was added recently
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -272,20 +272,23 @@ export const Project = () => { | |||
| tab.isEnterprise ? 'end' : undefined | |||
| } | |||
| icon={ | |||
| <span> | |||
| <> | |||
There was a problem hiding this comment.
❌ Getting worse: Complex Method
Project already has high cyclomatic complexity, and now it increases in Lines of Code from 276 to 278
| Beta | ||
| </StyledBadge> | ||
| // extra span to avoid badge getting color override from the overly specific parent component | ||
| <span> |
There was a problem hiding this comment.
moving this span around the styled badge to escape css rule with direct tab span child selector that gets the purple color
There was a problem hiding this comment.
Would it be sensible to update the styling on the tab span instead of adding the extra span? Feels like this fixes the symptom but not the cause. We might need to do the same thing again later? 💁🏼
There was a problem hiding this comment.
Would probably also make codescene happier
There was a problem hiding this comment.
Tab is a material UI component with a very specific rule for its direct span child. I'd need to overrider Material UI internals which I didn't want to do.
There was a problem hiding this comment.
Oh, right. Seems weird that they'd add that, but yeah, happy with your reasoning there.
| Beta | ||
| </StyledBadge> | ||
| // extra span to avoid badge getting color override from the overly specific parent component | ||
| <span> |
There was a problem hiding this comment.
Would probably also make codescene happier
About the changes
Important files
Discussion points