-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove strategy form feedback #6769
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
const { openFeedback, hasSubmittedFeedback } = useFeedback( | ||
feedbackCategory, | ||
'manual', | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ No longer an issue: Complex Method
FeatureStrategyForm (top-level context) is no longer above the threshold for cyclomatic complexity
@@ -584,7 +552,7 @@ export const FeatureStrategyForm = ({ | |||
<FeatureStrategyProdGuard | |||
open={showProdGuard} | |||
onClose={() => setShowProdGuard(false)} | |||
onClick={onSubmitWithFeedback} | |||
onClick={onSubmit} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ New issue: Complex Method
FeatureStrategyForm has a cyclomatic complexity of 38, threshold = 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
We are removing strategy form feedback in favor of new project overview feedback form.