Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: project overview refactor feedback behind a flag #6772

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Apr 3, 2024

About the changes

New project overview refactor feedback is behind a flag now

Important files

Discussion points

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 11:52am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2024 11:52am

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Comment on lines +115 to +117
if (
projectOverviewRefactorFeedback &&
!seenFeedback &&

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ New issue: Complex Conditional
useDelayedFeedbackPrompt has 1 complex conditionals with 2 branches, threshold = 2

Suppress

@kwasniew kwasniew merged commit 501acd0 into main Apr 3, 2024
16 checks passed
@kwasniew kwasniew deleted the project-overview-refactor-feedback-flag branch April 3, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants