fix: strategy targeting numeric also check value field #6774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API returns both value and values fields. Empty values array causes ui to think constraint doesnt have a value This commit checks if value field exists and is empty before returning check on values and length
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
+21
to
+23
| if ( | ||
| constraint.hasOwnProperty('values') && | ||
| (!constraint.hasOwnProperty('value') || constraint.value === '') |
There was a problem hiding this comment.
❌ New issue: Complex Conditional
filterConstraints has 1 complex conditionals with 2 branches, threshold = 2
kwasniew
approved these changes
Apr 4, 2024
daveleek
deleted the
fix/strategy-constraint-numeric-removed-on-change-tab
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
API returns both value and values fields. Empty values array causes ui to think constraint doesnt have a value
This PR checks if value field exists and is empty before returning check on values and length
Discussion points
Included a check on the value of the field in addition to checking if the field exists, I'll check the Open API spec but can we guarantee it doesn't exist without also having a value?
Should we check if the field is undefined? Feels like if it exists it's returned either with a value or as empty.