feat: feature lifecycle usage behind a flag #6786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
kwasniew
commented
Apr 5, 2024
| @@ -347,6 +349,9 @@ export const createServices = ( | |||
| const inactiveUsersService = new InactiveUsersService(stores, config, { | |||
| userService, | |||
| }); | |||
| const { featureLifecycleService } = | |||
| createFakeFeatureLifecycleService(config); | |||
There was a problem hiding this comment.
we'll switch this to prod impl when we're done with controller and testing the in-memory version
kwasniew
commented
Apr 5, 2024
| this.flagResolver = flagResolver; | ||
| } | ||
|
|
||
| private async checkEnabled(fn: () => Promise<void>) { |
There was a problem hiding this comment.
each event needs to be wrapped with a check because we want runtime control. If we put this around the listen method we'd only have startup control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
When get get DB migrations and SQL repository we'll switch to the real store.
In the next PR I'll expose the in-memory recorded lifecycle stages over API.
Important files
Discussion points