fix: total flags and flags per user when all projects #6787
Conversation
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -66,6 +71,7 @@ const ChartWidget = styled(Widget)(({ theme }) => ({ | |||
|
|
|||
| export const InsightsCharts: VFC<IChartsProps> = ({ | |||
| projects, | |||
| flags, | |||
There was a problem hiding this comment.
❌ Getting worse: Large Method
InsightsCharts:VFC<IChartsProps> increases from 137 to 147 lines of code, threshold = 120
| flags: InstanceInsightsSchemaFlags, | ||
| users: InstanceInsightsSchemaUsers, | ||
| ) { | ||
| const flagsPerUserCalculation = flags.total / users.total; |
There was a problem hiding this comment.
This function can receive more primitive type, and thus be simplified. I would pass flags.total and users.total instead of entire objects. Also formatFlagsPerUser would be more descriptive to me.
There was a problem hiding this comment.
Not sure I understand what you mean here
There was a problem hiding this comment.
This function doesn't need to have complex arguments. It can probably work with ? number | null arguments instead, and be called as formatFlagsPerUser(flags.total, users.total)
Fixes the flag stats flagsPerUser calculation and display value.
Previously the calculation depended on project data which might not be there with the permission changes
Closes # 1-2255