feat: Feature lifecycle sql store #6790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
kwasniew
changed the title
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
kwasniew
commented
Apr 5, 2024
|
|
||
| return results.map(({ stage, created_at }: DBType) => ({ | ||
| stage, | ||
| enteredStageAt: created_at, |
There was a problem hiding this comment.
will probably rename enteredStageAt to createdAt in the service and openapi
kwasniew
commented
Apr 5, 2024
| @@ -8,9 +8,12 @@ export class FakeFeatureLifecycleStore implements IFeatureLifecycleStore { | |||
| private lifecycles: Record<string, FeatureLifecycleView> = {}; | |||
|
|
|||
| async insert(featureLifecycleStage: FeatureLifecycleStage): Promise<void> { | |||
| const existing = await this.get(featureLifecycleStage.feature); | |||
| if (await this.stageExists(featureLifecycleStage)) { | |||
There was a problem hiding this comment.
prevent double inserts in fake impl
kwasniew
commented
Apr 5, 2024
| db.runSql( | ||
| ` | ||
| CREATE TABLE IF NOT EXISTS feature_lifecycles ( | ||
| feature VARCHAR(255) NOT NULL REFERENCES features(name) ON DELETE CASCADE, |
There was a problem hiding this comment.
we want to delete feature lifecycle when feature is removed
kwasniew
commented
Apr 5, 2024
| CREATE TABLE IF NOT EXISTS feature_lifecycles ( | ||
| feature VARCHAR(255) NOT NULL REFERENCES features(name) ON DELETE CASCADE, | ||
| stage VARCHAR(255) NULL, | ||
| created_at TIMESTAMP WITH TIME ZONE default now(), |
There was a problem hiding this comment.
sticking to generic name instead of specific stage_entered_at
There was a problem hiding this comment.
using timestamp with timezone to have the same type as features table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
await ms(randomTime)Important files
Discussion points