fix: dark mode background (#6803) #6804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the background of Legal values was white for dark mode <img width="758" alt="Screenshot 2024-04-09 at 10 10 16" src="https://github.com/Unleash/unleash/assets/104830839/6936be0f-fc60-49a3-b414-dbb32012f8be"> Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
ivarconr
approved these changes
Apr 9, 2024
ivarconr
reviewed
Apr 9, 2024
| @@ -4,7 +4,7 @@ export const StyledContainer = styled('div')(({ theme }) => ({ | |||
| display: 'inline-block', | |||
| wordBreak: 'break-word', | |||
| padding: theme.spacing(0.5, 1), | |||
| background: theme.palette.common.white, | |||
There was a problem hiding this comment.
I guess we seldom wants to see this value used?
There was a problem hiding this comment.
Indeed, this value might not be as useful any longer
daveleek
deleted the
chore/strategy-constraint-dark-mode-background-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Pulls in dark mode fix for strategy constraint legal values background from PR #6803 to be released in 5.11.1