fix: show loading features only when loading is happening #6817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
FredrikOseberg
commented
Apr 10, 2024
| @@ -0,0 +1,85 @@ | |||
| import { screen, fireEvent } from '@testing-library/react'; | |||
There was a problem hiding this comment.
Biome decided to format this file as well. It has not been touched, but had wrong formatting for some reason.
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| } | ||
|
|
||
| export const LeadTimeForChanges = ({ leadTime }: ILeadTimeForChangesProps) => { |
There was a problem hiding this comment.
❌ Getting worse: Large Method
LeadTimeForChanges increases from 196 to 199 lines of code, threshold = 120
FredrikOseberg
deleted the
fix/insights-showing-dummy-data-on-fresh-instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the dummy data would persist when there is no data coming from the API. This causes us to display dummy data in the dora metrics table which is not correct. This PR fixes that by only showing the loading features when we are actually loading.