feat: fill metrics summary missing datapoints with 0 #6820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -79,6 +80,7 @@ export const InsightsCharts: VFC<IChartsProps> = ({ | |||
| flagTrends, | |||
| groupedMetricsData, | |||
| environmentTypeTrends, | |||
| allMetricsDatapoints, | |||
There was a problem hiding this comment.
❌ Getting worse: Large Method
InsightsCharts:VFC<IChartsProps> increases from 147 to 149 lines of code, threshold = 120
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
andreas-unleash
commented
Apr 10, 2024
|
|
||
| export const useInsightsData = ( | ||
| executiveDashboardData: InstanceInsightsSchema, | ||
| instanceInsights: InstanceInsightsSchema, |
There was a problem hiding this comment.
renamed so that we use consistent language
sjaanus
approved these changes
Apr 10, 2024
andreas-unleash
deleted the
feat/fill_metrics_data_with_0_when_missing_datapoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fills missing datapoints with 0s so that all metrics chart lines have data for all datapoints.
Closes # 1-2278
Before:
After:
