chore: SCIM guard for users #6836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
nunogois
commented
Apr 11, 2024
nunogois
commented
Apr 11, 2024
| handleNotFound, | ||
| handleUnauthorized, | ||
| handleForbidden, | ||
| propagateErrors: true, |
There was a problem hiding this comment.
The reason for this change was to have proper errors in the UI toast, otherwise we would get cannot read property "msg" of undefined errors. I think this is a safe change. Can you please confirm @FredrikOseberg and @Tymek?
There was a problem hiding this comment.
Double checked with @FredrikOseberg and this should be safe as long as the calls to this hook's methods are wrapped in a try/catch, which they seem to be.
nunogois
commented
Apr 11, 2024
frontend/src/component/admin/users/UsersList/ChangePassword/ChangePassword.tsx
Show resolved
Hide resolved
sighphyre
reviewed
Apr 11, 2024
sighphyre
reviewed
Apr 11, 2024
sighphyre
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2093/api-should-not-allow-manual-management-of-scim-managed-users-in
Introduces a SCIM guard for SCIM users. SCIM users should be managed exclusively by the SCIM client, not Unleash.
We decided to be restrictive for now, completely covering all of the write methods, but may fine-tune some of this at a later stage.
Will eventually be followed up by a UI-centric PR.