feat: display removed context props in the UI #6844
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
frontend/src/component/playground/Playground/AdvancedPlayground.test.tsx
Show resolved
Hide resolved
thomasheartman
force-pushed
the
feat/show-removed-context-props-in-ui
branch
from
cb0703f
to
7f7cd71
Compare
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -28,6 +28,46 @@ const StyledAlert = styled(Alert)(({ theme }) => ({ | |||
| marginBottom: theme.spacing(3), | |||
| })); | |||
|
|
|||
| const GenerateWarningMessages: React.FC<{ | |||
There was a problem hiding this comment.
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.33 to 4.40, threshold = 4
frontend/src/component/playground/Playground/AdvancedPlayground.tsx
Outdated
Show resolved
Hide resolved
| <GenerateWarningMessages | ||
| response={results} | ||
| /> |
There was a problem hiding this comment.
This component will be null when no warning, I'm just wondering if this is ok (i.e. react knows how to handle null components). Even if react supports this, I remember we were using conditional rendering rather than returning null.
There was a problem hiding this comment.
I'm pretty sure that react knows how to handle nulls, yeah. I think it's even preferable to, say, a, fragment. ConditionallyRender also returns null if it's not rendering anything.
There was a problem hiding this comment.
And because in this case, the decision whether to render something or not can be a little complex (though I guess condition={results.warnings?.invalidContextProperties?.length > 0} would work), I think it makes sense to relegate it to the function instead.
Does that sound reasonable?
There was a problem hiding this comment.
Sounds reasonable! I kind of like this approach because it requires less boilerplate code (I mean, tags are boilerplate in a way). So I think it's good and something for my TIL list :)
This PR shows context warnings in the UI if they exist.
That means that if you provide invalid properties on the top level, you'll get the result back, but we'll also tell you that we didn't take these properties into account.
Screenie: