feat: start extracting project from session object #6856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sjaanus
changed the title
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -65,6 +65,7 @@ export const createStores = ( | |||
| db, | |||
| eventBus, | |||
| getLogger, | |||
| config.flagResolver, | |||
There was a problem hiding this comment.
❌ Getting worse: Large Method
createStores increases from 104 to 105 lines of code, threshold = 70
sjaanus
commented
Apr 15, 2024
| .onConflict(['app_name', 'project', 'environment']) | ||
| .merge(); | ||
| } | ||
|
|
||
| async bulkUpsert(apps: Partial<IClientApplication>[]): Promise<void> { | ||
| const rows = apps.map(remapRow); | ||
| const usageRows = apps.map(remapUsageRow); | ||
| const usageRows = apps.flatMap(this.remapUsageRow); |
There was a problem hiding this comment.
Since now it was array in array, we will flatmap it.
sjaanus
commented
Apr 15, 2024
| @@ -420,4 +421,30 @@ export default class ClientApplicationsStore | |||
| }, | |||
| }; | |||
| } | |||
|
|
|||
| private remapUsageRow = (input) => { | |||
There was a problem hiding this comment.
Added case, when input is list of projects instead of just single project.
Yes there was some coverage and added another test. |
FredrikOseberg
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were extracting the project from the token, but now we will retrieve it from the session, which contains the full list of projects.
This change also resolves an issue we encountered when the token was a multi-project token, formatted as []:dev:token. Previously, it was unable to display the exact list of projects. Now, it will show the exact project names.