Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added IAuditUser to request with middleware #6857

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

chriswk
Copy link
Contributor

@chriswk chriswk commented Apr 15, 2024

Adds a middleware which adds our needed audit info as a separate object to the request.

@chriswk chriswk requested a review from sighphyre April 15, 2024 10:51
@chriswk chriswk self-assigned this Apr 15, 2024
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 7:35am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 7:35am

@chriswk chriswk marked this pull request as ready for review April 15, 2024 11:18
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

@@ -176,6 +177,7 @@ export default async function getApp(
rbacMiddleware(config, stores, services.accessService),
);

app.use(`${baseUriPath}/api/admin`, auditAccessMiddleware(config));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Getting worse: Complex Method
getApp already has high cyclomatic complexity, and now it increases in Lines of Code from 159 to 160

Suppress

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

@chriswk chriswk merged commit 633cae6 into main Apr 18, 2024
6 of 7 checks passed
@chriswk chriswk deleted the task/addUserAuditInfo branch April 18, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants