chore: UI SCIM guard for groups #6866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
daveleek
reviewed
Apr 16, 2024
| color='primary' | ||
| disabled={scimEnabled || !isValid} | ||
| data-testid={UG_SAVE_BTN_ID} | ||
| title='test' |
There was a problem hiding this comment.
Intentional? or should the title be something different here?
There was a problem hiding this comment.
Absolutely not intentional. Great catch!
There was a problem hiding this comment.
daveleek
approved these changes
Apr 16, 2024
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
+137
to
+141
| title={ | ||
| isScimGroup | ||
| ? scimGroupTooltip | ||
| : 'Remove user from group' | ||
| } |
There was a problem hiding this comment.
❌ Getting worse: Complex Method
Group:VFC.columns increases in cyclomatic complexity from 16 to 17, threshold = 10
daveleek
reviewed
Apr 17, 2024
Comment on lines
56
to
60
| const scimEnabled = | ||
| isEnterprise() && | ||
| scimSettingEnabled && | ||
| scimFlagEnabled && | ||
| Boolean(group?.scimId); |
There was a problem hiding this comment.
Ok so the useScimSettings().enabled already covers this making it redundant
There was a problem hiding this comment.
Correct, that's what I'm thinking 👍
daveleek
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2113/ui-should-not-allow-manual-management-of-scim-managed-groups-in
Adds a UI SCIM guard when trying to manage groups.
The condition for the guard is:
Similar to #6859