Feat: new projects list #6873

@@ -139,6 +149,7 @@ export const ProjectListNew = () => {
    );

    const showProjectFilterButtons = useUiFlag('projectListFilterMyProjects');
+    const projectsListNewCards = useUiFlag('projectsListNewCards');


❌ Getting worse: Complex Method
ProjectListNew increases in cyclomatic complexity from 21 to 23, threshold = 10

_Suppress

thomasheartman · 2024-04-18T08:23:18Z

frontend/src/component/project/ProjectCard/ProjectCardFooter/ProjectCardFooter.tsx

+    padding: theme.spacing(1, 2),
+    borderTop: `1px solid ${theme.palette.grey[300]}`,
+    backgroundColor: theme.palette.grey[100],
+    boxShadow: 'inset 0px 2px 4px rgba(32, 32, 33, 0.05)', // FIXME: replace with variable


don't we have variable for this yet?

thomasheartman · 2024-04-18T08:24:37Z

frontend/src/component/project/ProjectList/ProjectList.tsx

@@ -139,6 +149,7 @@ export const ProjectListNew = () => {
    );

    const showProjectFilterButtons = useUiFlag('projectListFilterMyProjects');
+    const projectsListNewCards = true;


You probably meant to make this depend on the UI flag, right?

frontend/src/component/project/ProjectCard/ProjectCardIcon/ProjectCardIcon.tsx

thomasheartman · 2024-04-18T08:28:26Z

frontend/src/component/project/ProjectCard/ProjectCardFooter/ProjectCardFooter.tsx

+    borderTop: `1px solid ${theme.palette.grey[300]}`,
+    backgroundColor: theme.palette.grey[100],


How does this work in dark mode? Feels kinda weird to use the palette directly instead of color names?

This is a placeholder for now.

thomasheartman · 2024-04-18T08:31:46Z

frontend/src/component/project/LegacyProjectCard/LegacyProjectCard.styles.ts

I'm assuming that the Legacy... stuff is just the old cards renamed?
Can we instead consider naming the new stuff New...? That serves two purposes:

PR size: It makes the set of changes smaller. It doesn't look like you've added an extra 250 lines of code.

Consistency: We have no other components in the front end called Legacy.... However, we do have a number of components called New.... I think we should stick to that pattern.

What do you think?

thomasheartman · 2024-04-18T08:50:00Z

frontend/src/component/project/ProjectCard/ProjectCard.styles.ts

    display: '-webkit-box',
    boxOrient: 'vertical',
    textOverflow: 'ellipsis',
    overflow: 'hidden',
    alignItems: 'flex-start',
+    WebkitBoxOrient: 'vertical',


This is deprecated (according to MDN). Can we use a different property?

thomasheartman · 2024-04-18T08:55:58Z

frontend/src/component/project/ProjectCard/ProjectCard.tsx

+                <StyledDivHeader data-loading>
+                    <ProjectCardIcon mode={mode} />
+                    <StyledBox>
+                        <StyledH2Title>{name}</StyledH2Title>


Should be h3

thomasheartman · 2024-04-18T08:57:13Z

frontend/src/component/project/ProjectCard/ProjectCard.tsx

+                        <StyledParagraphInfo data-loading>
+                            {featureCount}
+                        </StyledParagraphInfo>
+                        <p data-loading>toggles</p>


Suggested change

<p data-loading>toggles</p>

<p data-loading>Flags</p>

thomasheartman · 2024-04-18T08:59:26Z

frontend/src/component/project/ProjectCard/ProjectCard.tsx

+                        <StyledParagraphInfo data-loading>
+                            {health}%
+                        </StyledParagraphInfo>
+                        <p data-loading>health</p>


Should be one paragraph. The number can be in a span if it needs to be styled differently.

…jectCardIcon.tsx Co-authored-by: Thomas Heartman <thomas@getunleash.io>

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Tymek · 2024-04-18T09:10:40Z

TODO: test 0 members project

Tymek added 2 commits April 16, 2024 16:28

feat: projects list grid

dafe204

feat: new project card

88562df

github-actions bot assigned Tymek Apr 16, 2024

codescene-delta-analysis bot reviewed Apr 16, 2024

View reviewed changes

improve project icon tooltips

2f21c5b

codescene-delta-analysis bot reviewed Apr 18, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 18, 2024 07:05 View deployment

Merge branch 'main' into feat/new-projects-list

acee03c

codescene-delta-analysis bot reviewed Apr 18, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-docs April 18, 2024 07:27 View deployment

vercel bot deployed to Preview – unleash-monorepo-frontend April 18, 2024 07:29 View deployment

Tymek changed the title ~~Feat/new projects list~~ Feat: new projects list Apr 18, 2024

codescene-delta-analysis bot reviewed Apr 18, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 18, 2024 07:38 View deployment

Tymek requested a review from thomasheartman April 18, 2024 07:41

refactor: projects list flag

60320dd

Tymek force-pushed the feat/new-projects-list branch from c665cd2 to 60320dd Compare April 18, 2024 07:47

Tymek marked this pull request as ready for review April 18, 2024 07:47

codescene-delta-analysis bot reviewed Apr 18, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 18, 2024 07:48 View deployment

codescene-delta-analysis bot reviewed Apr 18, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 18, 2024 07:53 View deployment

Tymek force-pushed the feat/new-projects-list branch from ace7513 to b8c1008 Compare April 18, 2024 08:35

codescene-delta-analysis bot reviewed Apr 18, 2024

View reviewed changes

update snapshot

d4f47fc

Tymek force-pushed the feat/new-projects-list branch from b8c1008 to d4f47fc Compare April 18, 2024 08:36

codescene-delta-analysis bot reviewed Apr 18, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 18, 2024 08:38 View deployment

thomasheartman reviewed Apr 18, 2024

View reviewed changes

Tymek and others added 2 commits April 18, 2024 11:00

Update frontend/src/component/project/ProjectCard/ProjectCardIcon/Pro…

d9789c4

…jectCardIcon.tsx Co-authored-by: Thomas Heartman <thomas@getunleash.io>

Update frontend/src/component/project/ProjectCard/ProjectCardIcon/Pro…

d280324

…jectCardIcon.tsx Co-authored-by: Thomas Heartman <thomas@getunleash.io>

codescene-delta-analysis bot reviewed Apr 18, 2024

View reviewed changes

thomasheartman approved these changes Apr 18, 2024

View reviewed changes

project card legacy to new

22a8186

codescene-delta-analysis bot reviewed Apr 18, 2024

View reviewed changes

fix project list card imports

d0444fe

codescene-delta-analysis bot reviewed Apr 18, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 18, 2024 09:08 View deployment

Tymek merged commit fd4bcff into main Apr 18, 2024
13 of 14 checks passed

Tymek deleted the feat/new-projects-list branch April 18, 2024 09:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: new projects list #6873

Feat: new projects list #6873

Tymek commented Apr 16, 2024 •

edited

Loading

vercel bot commented Apr 16, 2024 •

edited

Loading

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot Apr 18, 2024

thomasheartman Apr 18, 2024

thomasheartman Apr 18, 2024

thomasheartman Apr 18, 2024

thomasheartman Apr 18, 2024

thomasheartman Apr 18, 2024

thomasheartman Apr 18, 2024

thomasheartman Apr 18, 2024

thomasheartman Apr 18, 2024

thomasheartman Apr 18, 2024

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

Tymek commented Apr 18, 2024

		borderTop: `1px solid ${theme.palette.grey[300]}`,
		backgroundColor: theme.palette.grey[100],

Feat: new projects list #6873

Feat: new projects list #6873

Conversation

Tymek commented Apr 16, 2024 • edited Loading

About the changes

vercel bot commented Apr 16, 2024 • edited Loading

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot Apr 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Tymek commented Apr 18, 2024

Tymek commented Apr 16, 2024 •

edited

Loading

vercel bot commented Apr 16, 2024 •

edited

Loading