Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feature lifecycle getter hook #6876

Merged
merged 2 commits into from
Apr 18, 2024
Merged

feat: feature lifecycle getter hook #6876

merged 2 commits into from
Apr 18, 2024

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Apr 16, 2024

No description provided.

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 7:56am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 7:56am

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we just need to fix the ouput interface naming before we merge.

import handleErrorResponses from '../httpErrorResponseHandler';
import type { FeatureLifecycleSchema } from 'openapi';

interface IUseInsightsDataOutput {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to change.

@sjaanus sjaanus merged commit f0ef7a6 into main Apr 18, 2024
13 checks passed
@sjaanus sjaanus deleted the lifecycle-getter branch April 18, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants