feat: restyle the project meta box #6880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
sjaanus
commented
Apr 17, 2024
| @@ -77,7 +75,11 @@ const FeatureOverviewMetaData = () => { | |||
| marginRight: theme.spacing(2), | |||
| height: '40px', | |||
| width: '40px', | |||
| padding: theme.spacing(0.5), | |||
There was a problem hiding this comment.
Wanted to make it styled component, but was not able to because how IconComponent is created.
There was a problem hiding this comment.
You can still refactor it to a separate component if you'd like to.
sjaanus
commented
Apr 17, 2024
| @@ -58,6 +58,7 @@ const theme = { | |||
| fontSizes: { | |||
| extraLargeHeader: '2.5rem', | |||
| largeHeader: '2rem', | |||
| mediumHeader: '1.5rem', | |||
There was a problem hiding this comment.
We were missing this fontsize.
Tymek
approved these changes
Apr 18, 2024
| @@ -77,7 +75,11 @@ const FeatureOverviewMetaData = () => { | |||
| marginRight: theme.spacing(2), | |||
| height: '40px', | |||
| width: '40px', | |||
| padding: theme.spacing(0.5), | |||
There was a problem hiding this comment.
You can still refactor it to a separate component if you'd like to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old:
New: