feat: split projects view into "my projects" and "other projects" #6886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
thomasheartman
commented
Apr 18, 2024
Comment on lines
159
to
176
| const projectsLists = useMemo(() => { | ||
| if (!splitProjectList) { | ||
| return { my: [], other: projects }; | ||
| } | ||
|
|
||
| const my: IProjectCard[] = []; | ||
| const other: IProjectCard[] = []; | ||
|
|
||
| for (const project of filteredProjects) { | ||
| console.log('handling', project); | ||
| if (shouldDisplayInMyProjects(myProjects)(project)) { | ||
| my.push(project); | ||
| } else { | ||
| other.push(project); | ||
| } | ||
| } | ||
| return { my, other }; | ||
| }, [filteredProjects, myProjects, splitProjectList]); |
There was a problem hiding this comment.
I wanna extract this into its own function so that I can test it properly.
thomasheartman
commented
Apr 18, 2024
Comment on lines
210
to
300
| const ProjectGroup: React.FC<{ | ||
| sectionTitle?: string; | ||
| projects: IProjectCard[]; | ||
| }> = ({ sectionTitle, projects }) => { | ||
| return ( | ||
| <StyledProjectGroupContainer> | ||
| <ConditionallyRender | ||
| condition={Boolean(sectionTitle)} | ||
| show={ | ||
| <Typography component='h3'>{sectionTitle}</Typography> | ||
| } | ||
| /> | ||
| <ConditionallyRender | ||
| condition={projects.length < 1 && !loading} | ||
| show={ | ||
| <ConditionallyRender | ||
| condition={searchValue?.length > 0} | ||
| show={ | ||
| <TablePlaceholder> | ||
| No projects found matching “ | ||
| {searchValue} | ||
| ” | ||
| </TablePlaceholder> | ||
| } | ||
| elseShow={ | ||
| <TablePlaceholder> | ||
| No projects available. | ||
| </TablePlaceholder> | ||
| } | ||
| /> | ||
| } | ||
| elseShow={ | ||
| <StyledItemsContainer> | ||
| <ConditionallyRender | ||
| condition={loading} | ||
| show={() => | ||
| loadingData.map((project: IProjectCard) => ( | ||
| <ProjectCard | ||
| data-loading | ||
| onHover={() => {}} | ||
| key={project.id} | ||
| name={project.name} | ||
| id={project.id} | ||
| mode={project.mode} | ||
| memberCount={2} | ||
| health={95} | ||
| featureCount={4} | ||
| /> | ||
| )) | ||
| } | ||
| elseShow={() => ( | ||
| <> | ||
| {projects.map( | ||
| (project: IProjectCard) => ( | ||
| <StyledCardLink | ||
| key={project.id} | ||
| to={`/projects/${project.id}`} | ||
| > | ||
| <ProjectCard | ||
| onHover={() => | ||
| handleHover( | ||
| project.id, | ||
| ) | ||
| } | ||
| name={project.name} | ||
| mode={project.mode} | ||
| memberCount={ | ||
| project.memberCount ?? | ||
| 0 | ||
| } | ||
| health={project.health} | ||
| id={project.id} | ||
| featureCount={ | ||
| project.featureCount | ||
| } | ||
| isFavorite={ | ||
| project.favorite | ||
| } | ||
| /> | ||
| </StyledCardLink> | ||
| ), | ||
| )} | ||
| </> | ||
| )} | ||
| /> | ||
| </StyledItemsContainer> | ||
| } | ||
| /> | ||
| </StyledProjectGroupContainer> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
This is just extracting the component that was already there, so that we can use it in two places. However, it feels pretty gnarly.
I'm unsure about moving it out into its own file, though, because then we'd have to add five extra parameters to the function:
loadingsearchValueCardComponentContainerComponenthandleHover
Still, it might be a neater approach. What do you think?
There was a problem hiding this comment.
Update: I went ahead with extracting this into its own file. I think it's the right thing to do.
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| const projectsListNewCards = useUiFlag('projectsListNewCards'); | ||
| const filters = ['All projects', 'My projects']; | ||
| const [filter, setFilter] = useState(filters[0]); | ||
| const splitProjectList = useUiFlag('projectListFilterMyProjects'); |
There was a problem hiding this comment.
✅ Getting better: Complex Method
ProjectListNew decreases in cyclomatic complexity from 23 to 17, threshold = 10
Tymek
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the previous "my projects" filter in favor always splitting projects, but showing both on the main screen.
To make it a bit easier to work with, it also moves the project group component into its own file, causing some extra lines of code change. My apologies 🙇🏼