Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly applied styles to Figure component in docs #6894

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

alvinometric
Copy link
Contributor

@alvinometric alvinometric commented Apr 19, 2024

It turns out the styles that we had in style.modules.css were overridden by browser defaults.

Before

image

After

image

Now taking into account all the styles that were in the CSS files (notice margin and border)

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview Apr 19, 2024 10:46am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview Apr 19, 2024 10:46am

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

@alvinometric alvinometric changed the title Using scoped CSS modules for Figure component in docs Correctly applied styles to Figure component in docs Apr 19, 2024
@alvinometric alvinometric merged commit a71d794 into main Apr 19, 2024
16 checks passed
@alvinometric alvinometric deleted the alvin/scoped-css-modules-figure branch April 19, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants