Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Stage timeline styling #6903

Merged
merged 5 commits into from
Apr 23, 2024
Merged

feat: Stage timeline styling #6903

merged 5 commits into from
Apr 23, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Apr 23, 2024

About the changes

Screenshot 2024-04-23 at 08 55 48

Styling stage timeline.

Design decisions:

  • stages and lines modelled as centered flexbox elements
  • stage box has :after content so that we can easily add active/inactive text below without affecting stages alignment
  • active stage modelled as a speech bubble with a CSS drawn rectangle. Originally I tried to use the MUI tooltip but it opens only on hover

Important files

Discussion points

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 7:01am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 7:01am

@kwasniew kwasniew changed the title Stage timeline styling feat: Stage timeline styling Apr 23, 2024
Copy link
Contributor

@sjaanus sjaanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. I was thinking of making these with css, but svg is nice.

@kwasniew kwasniew merged commit d59f1ad into main Apr 23, 2024
13 checks passed
@kwasniew kwasniew deleted the stage-timeline-styling branch April 23, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants