Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a bunch of logs to validate api token validation behavior #6905

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

gastonfournier
Copy link
Contributor

This change is meant to test something in sandbox. It will be reverted after the investigation.

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Apr 23, 2024 8:57am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Apr 23, 2024 8:57am

@gastonfournier gastonfournier changed the title chore: add a bunch of logs to validate the behavior chore: add a bunch of logs to validate api token validation behavior Apr 23, 2024
@@ -193,6 +213,7 @@ export class ApiTokenService {
secret: string,
): Promise<IApiUser | undefined> {
const token = await this.getTokenWithCache(secret);
this.logger.info(`getUserForToken ${secret} found: ${token}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably gotta come out so just a reminder that we gotta revert this one when we're done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastonfournier gastonfournier merged commit dec107a into main Apr 23, 2024
9 checks passed
@gastonfournier gastonfournier deleted the auth-logs branch April 23, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants