chore: remove logs for secret and change invalid token query logic #6907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
+148
to
+175
| if (!token) { | ||
| if (isPast(nextAllowedQuery)) { | ||
| this.logger.info(`Token not found in cache, querying database`); | ||
| if (this.queryAfter.size > 1000) { | ||
| // establish a max limit for queryAfter size to prevent memory leak | ||
| this.logger.info( | ||
| 'queryAfter size exceeded 1000, clearing cache', | ||
| ); | ||
| this.queryAfter.clear(); | ||
| } | ||
|
|
||
| const stopCacheTimer = this.timer('getTokenWithCache.query'); | ||
| token = await this.store.get(secret); | ||
| if (token) { | ||
| if (token?.expiresAt && isPast(token.expiresAt)) { | ||
| this.logger.info('Token has expired'); | ||
| // prevent querying the same invalid secret multiple times. Expire after 5 minutes | ||
| this.queryAfter.set(secret, addMinutes(new Date(), 5)); | ||
| token = undefined; | ||
| } else { | ||
| this.activeTokens.push(token); | ||
| } | ||
| } else { | ||
| // prevent querying the same invalid secret multiple times. Expire after 5 minutes | ||
| this.queryAfter.set(secret, addMinutes(new Date(), 5)); | ||
| } | ||
| stopCacheTimer(); | ||
| } else { |
There was a problem hiding this comment.
❌ Getting worse: Complex Method
ApiTokenService.getTokenWithCache increases in cyclomatic complexity from 9 to 12, threshold = 9
There was a problem hiding this comment.
Code scene kinda has a point here imo
Comment on lines
+148
to
+175
| if (!token) { | ||
| if (isPast(nextAllowedQuery)) { | ||
| this.logger.info(`Token not found in cache, querying database`); | ||
| if (this.queryAfter.size > 1000) { | ||
| // establish a max limit for queryAfter size to prevent memory leak | ||
| this.logger.info( | ||
| 'queryAfter size exceeded 1000, clearing cache', | ||
| ); | ||
| this.queryAfter.clear(); | ||
| } | ||
|
|
||
| const stopCacheTimer = this.timer('getTokenWithCache.query'); | ||
| token = await this.store.get(secret); | ||
| if (token) { | ||
| if (token?.expiresAt && isPast(token.expiresAt)) { | ||
| this.logger.info('Token has expired'); | ||
| // prevent querying the same invalid secret multiple times. Expire after 5 minutes | ||
| this.queryAfter.set(secret, addMinutes(new Date(), 5)); | ||
| token = undefined; | ||
| } else { | ||
| this.activeTokens.push(token); | ||
| } | ||
| } else { | ||
| // prevent querying the same invalid secret multiple times. Expire after 5 minutes | ||
| this.queryAfter.set(secret, addMinutes(new Date(), 5)); | ||
| } | ||
| stopCacheTimer(); | ||
| } else { |
There was a problem hiding this comment.
❌ New issue: Bumpy Road Ahead
ApiTokenService.getTokenWithCache has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function
Comment on lines
+148
to
+175
| if (!token) { | ||
| if (isPast(nextAllowedQuery)) { | ||
| this.logger.info(`Token not found in cache, querying database`); | ||
| if (this.queryAfter.size > 1000) { | ||
| // establish a max limit for queryAfter size to prevent memory leak | ||
| this.logger.info( | ||
| 'queryAfter size exceeded 1000, clearing cache', | ||
| ); | ||
| this.queryAfter.clear(); | ||
| } | ||
|
|
||
| const stopCacheTimer = this.timer('getTokenWithCache.query'); | ||
| token = await this.store.get(secret); | ||
| if (token) { | ||
| if (token?.expiresAt && isPast(token.expiresAt)) { | ||
| this.logger.info('Token has expired'); | ||
| // prevent querying the same invalid secret multiple times. Expire after 5 minutes | ||
| this.queryAfter.set(secret, addMinutes(new Date(), 5)); | ||
| token = undefined; | ||
| } else { | ||
| this.activeTokens.push(token); | ||
| } | ||
| } else { | ||
| // prevent querying the same invalid secret multiple times. Expire after 5 minutes | ||
| this.queryAfter.set(secret, addMinutes(new Date(), 5)); | ||
| } | ||
| stopCacheTimer(); | ||
| } else { |
There was a problem hiding this comment.
❌ New issue: Deep, Nested Complexity
ApiTokenService.getTokenWithCache has a nested complexity depth of 4, threshold = 4
chriswk
approved these changes
Apr 23, 2024
sighphyre
reviewed
Apr 23, 2024
gastonfournier
commented
Apr 23, 2024
Yes, I'm aware of the additional complexity but for the sake of time and moving on to other important tasks I'll let this one slip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
What's going on is the following:
unleash/src/lib/services/api-token-service.ts
Line 162 in 54383a6
unleash/src/lib/services/api-token-service.ts
Lines 164 to 165 in 54383a6
The token was added to the cache because we were not checking if it had expired. Now we added a check and we also have a log for expired tokens. Some improvement opportunities: