Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Completed stage UI #6917

Merged
merged 3 commits into from
Apr 24, 2024
Merged

feat: Completed stage UI #6917

merged 3 commits into from
Apr 24, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Apr 24, 2024

About the changes

Completed but active traffic in prod for the last 2 days:
Screenshot 2024-04-24 at 10 31 43

Completed and safe to archive since no traffic in the last 2 days:
Screenshot 2024-04-24 at 10 31 30

Details:

  • currently a decision if it's safe to archive is done frontend side but we may consider moving it server side

Important files

Discussion points

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend 🛑 Canceled (Inspect) Apr 24, 2024 8:42am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 8:42am

@kwasniew kwasniew requested a review from sjaanus April 24, 2024 08:40
@kwasniew kwasniew changed the title Completed stage UI feat: Completed stage UI Apr 24, 2024
@FredrikOseberg
Copy link
Contributor

Archive button text seems to be a lot larger than the usual button size. Could we use the default size?

@kwasniew
Copy link
Contributor Author

@FredrikOseberg I set the size to the smallest one we have in the sizes. The only way to achieve the small font is to !important fontSize since explicit fontSize is overwritten by the permission button component.

@kwasniew kwasniew merged commit 9c883ca into main Apr 24, 2024
13 checks passed
@kwasniew kwasniew deleted the completed-stage-ui branch April 24, 2024 09:00
@FredrikOseberg
Copy link
Contributor

FredrikOseberg commented Apr 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants