Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added a check to avoid double counting #6925

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

chriswk
Copy link
Contributor

@chriswk chriswk commented Apr 25, 2024

Due to how we handle redirects of embedded proxy, we ended up counting the same request twice. This PR adds a boolean to res.locals which we then check if set to avoid double counting.

@chriswk chriswk requested a review from ivarconr April 25, 2024 08:04
Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Apr 25, 2024 8:04am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Apr 25, 2024 8:04am

@chriswk chriswk merged commit af54e27 into main Apr 25, 2024
9 checks passed
@chriswk chriswk deleted the fix/doubleCountingProxyRedirects branch April 25, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants