feat: scim assume control UI - move scim into sso configs #6929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a callback to be invoked from sso settings page when saving. Removes scim settings tab
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
-21
to
-22
| const scimEnabled = useUiFlag('scimApi'); | ||
|
|
There was a problem hiding this comment.
✅ No longer an issue: Large Method
AuthSettings is no longer above the threshold for lines of code
Comment on lines
+92
to
+107
| const { | ||
| settings, | ||
| enabled, | ||
| setEnabled, | ||
| assumeControlOfExisting, | ||
| setAssumeControlOfExisting, | ||
| newToken, | ||
| tokenGenerationDialog, | ||
| setTokenGenerationDialog, | ||
| tokenDialog, | ||
| setTokenDialog, | ||
| loading: scimLoading, | ||
| saveScimSettings, | ||
| onGenerateNewTokenConfirm, | ||
| } = useScim(); | ||
|
|
There was a problem hiding this comment.
❌ Getting worse: Large Method
OidcAuth increases from 266 to 307 lines of code, threshold = 120
Comment on lines
+83
to
+98
| const { | ||
| settings, | ||
| enabled, | ||
| setEnabled, | ||
| assumeControlOfExisting, | ||
| setAssumeControlOfExisting, | ||
| newToken, | ||
| tokenGenerationDialog, | ||
| setTokenGenerationDialog, | ||
| tokenDialog, | ||
| setTokenDialog, | ||
| loading: scimLoading, | ||
| saveScimSettings, | ||
| onGenerateNewTokenConfirm, | ||
| } = useScim(); | ||
|
|
There was a problem hiding this comment.
❌ Getting worse: Large Method
SamlAuth increases from 242 to 283 lines of code, threshold = 120
chriswk
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes