🟢 feat: Add bearer token support #6934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -64,14 +59,9 @@ describe('bearerTokenMiddleware', () => { | |||
| expect(req.headers.authorization).toBe(exampleSignalToken); | |||
| }); | |||
|
|
|||
| it('should always run for signal endpoint, regardless of the flag', () => { | |||
There was a problem hiding this comment.
ℹ Getting worse: Code Duplication
introduced similar code in: 'should always run for signal endpoint, regardless of the flag, with base path','should always run for signal endpoint, without base path'
| @@ -16,11 +16,6 @@ describe('bearerTokenMiddleware', () => { | |||
| beforeEach(() => { | |||
| config = createTestConfig({ | |||
| getLogger, | |||
| experimental: { | |||
There was a problem hiding this comment.
✅ Getting better: Code Duplication
reduced similar code in: 'should always run for signal endpoint, regardless of the flag','should always run for signal endpoint, regardless of the flag, supporting instance path'
ivarconr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Removes the bearer token middleware flag for GA