Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: archive feature from lifecycle #6938

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Apr 25, 2024

About the changes

Can archive feature from the completed lifecycle stage.

Details:

  • added modal for archive at the meta data component level. This component owns featureId and projectId that are needed for the archive.
  • modal handles regular and change request flow
  • passing archive action to the lifecycle tooltip so that we don't need to pass modal itself very deep down
  • test verifying that archive action is invoked from the completed lifecycle stage

Important files

Discussion points

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 7:24am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 7:24am

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Comment on lines +85 to +86
const navigate = useNavigate();
const [showDelDialog, setShowDelDialog] = useState(false);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ New issue: Large Method
FeatureOverviewMetaData has 120 lines, threshold = 120

Suppress

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

@kwasniew kwasniew merged commit 675e1a9 into main Apr 26, 2024
12 of 13 checks passed
@kwasniew kwasniew deleted the archive-feature-from-lifecycle branch April 26, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant