feat: revived feature goes to initial lifecycle stage #6944
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
|
|
||
| eventStore.emit(FEATURE_REVIVED, { featureName }); | ||
| await reachedStage('initial'); | ||
| const initialLifecycle = | ||
| await featureLifecycleService.getFeatureLifecycle(featureName); | ||
| expect(initialLifecycle).toEqual([ | ||
| { stage: 'initial', enteredStageAt: expect.any(Date) }, | ||
| ]); |
There was a problem hiding this comment.
❌ New issue: Large Method
'can insert and read lifecycle stages' has 71 lines, threshold = 70
| @@ -155,4 +161,9 @@ export class FeatureLifecycleService extends EventEmitter { | |||
| ]); | |||
| this.emit(STAGE_ENTERED, { stage: 'archived' }); | |||
| } | |||
|
|
|||
| private async featureRevived(feature: string) { | |||
| await this.featureLifecycleStore.delete(feature); | |||
There was a problem hiding this comment.
delete all previous stages
There was a problem hiding this comment.
LG, but I was thinking about it. If we want to measure how long we were in each stage, this makes it not countable, the first stage. Unless we take it from feature created date.
But if we use created date, then after revive, the created date could have been 2 years ago.
There was a problem hiding this comment.
We need an opinion here. One option would be to delete all events expect from the initial event. So when you revive you only erase later stages.
There was a problem hiding this comment.
Since I don't know which is better I'll merge it now with an easy option to change it later
|
|
||
| private async featureRevived(feature: string) { | ||
| await this.featureLifecycleStore.delete(feature); | ||
| await this.featureInitialized(feature); |
There was a problem hiding this comment.
re-initialize with a new date
About the changes
Revived feature goes back to the initial stage. This is a new initial stage with a date matching the revive time.
Important files
Discussion points