feat: feature completed connected to backend #6947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -79,16 +80,22 @@ export const StyledLabel = styled('span')(({ theme }) => ({ | |||
| const FeatureOverviewMetaData = () => { | |||
| const projectId = useRequiredPathParam('projectId'); | |||
| const featureId = useRequiredPathParam('featureId'); | |||
| const { feature } = useFeature(projectId, featureId); | |||
| const { feature, refetchFeature } = useFeature(projectId, featureId); | |||
There was a problem hiding this comment.
❌ Getting worse: Large Method
FeatureOverviewMetaData increases from 120 to 127 lines of code, threshold = 120
kwasniew
approved these changes
Apr 26, 2024
| @@ -11,9 +11,19 @@ const twoMinutesAgo = '2024-04-25T08:03:00.000Z'; | |||
| const oneHourAgo = '2024-04-25T07:05:00.000Z'; | |||
| const twoHoursAgo = '2024-04-25T06:05:00.000Z'; | |||
|
|
|||
| const renderOpenTooltip = (stage: LifecycleStage, onArchive = () => {}) => { | |||
| const renderOpenTooltip = ( | |||
There was a problem hiding this comment.
❌ New issue: Code Duplication
The module contains 2 functions with similar structure: 'render live stage','render pre-live stage'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects feature complete to backend