feat: Project owners UI #6949

I've got some questions about the implementation, though. But it's a lot of lines of code, so it's hard to follow. Can we walk through it together on Monday?

thomasheartman · 2024-04-26T12:33:10Z

...c/component/admin/groups/GroupsList/GroupCard/GroupCardAvatars/GroupPopover/GroupPopover.tsx

@@ -44,7 +44,7 @@ export const GroupPopover = ({
            }}
        >
            <StyledName>{user?.name || user?.username}</StyledName>
-            <div>{user?.email}</div>
+            <div>{user?.description || user?.email}</div>


I'm a little unsure about this one: why are you changing the behavior of an existing component here? Will this have unintended consequences? Do we even use group descriptions in the new api? Isn't it just the group name?

...erview/FeatureOverviewEnvironments/FeatureOverviewEnvironment/FeatureOverviewEnvironment.tsx

frontend/src/component/project/NewProjectCard/NewProjectCard.styles.ts

frontend/src/component/project/NewProjectCard/ProjectOwners/ProjectOwners.tsx

thomasheartman · 2024-04-26T12:42:21Z

frontend/src/component/project/ProjectList/ProjectGroup.tsx

+                    <Typography
+                        component='h2'
+                        variant='h3'
+                        sx={(theme) => ({ marginBottom: theme.spacing(2) })}


Why did you move this out of a styled component and into sx?

thomasheartman · 2024-04-26T12:43:47Z

frontend/src/component/project/ProjectList/ProjectList.tsx

+const StyledContainer = styled('div')(({ theme }) => ({
+    display: 'flex',
+    flexDirection: 'column',
+    gap: theme.spacing(4),
+}));


So you moved the spacing here, right: why? For readability? I agree that it makes sense to let the parent control how items within it are spaced, but it adds another layer of nesting 🤷🏼

src/lib/features/project/project-owners-read-model.ts

thomasheartman · 2024-04-26T12:45:38Z

frontend/src/component/common/Badge/Badge.tsx

Does the badge have children?

thomasheartman · 2024-04-26T12:46:09Z

frontend/src/component/project/NewProjectCard/NewProjectCard.tsx

Let's review this one later

codescene-delta-analysis

✅ Code Health Quality Gates: OK

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

codescene-delta-analysis

✅ Code Health Quality Gates: OK

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

frontend/src/component/project/ProjectList/ProjectGroup.tsx

thomasheartman · 2024-04-29T09:35:36Z

frontend/src/component/project/NewProjectCard/NewProjectCard.tsx

+                            <StyledParagraphInfo data-loading>
+                                {memberCount}
+                            </StyledParagraphInfo>
+                            <p data-loading>
+                                {memberCount === 1 ? 'member' : 'members'}
+                            </p>


Should be one paragraph, not two

frontend/src/component/project/NewProjectCard/NewProjectCard.tsx

thomasheartman · 2024-04-29T09:36:57Z

frontend/src/component/project/NewProjectCard/NewProjectCard.tsx

+                    <StyledParagraphInfo data-loading>
+                        {health}%
+                    </StyledParagraphInfo>
+                    <p data-loading>health</p>


This should also be one paragraph

Co-authored-by: Thomas Heartman <thomas@getunleash.io>

codescene-delta-analysis

✅ Code Health Quality Gates: OK

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

codescene-delta-analysis

✅ Code Health Quality Gates: OK

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

thomasheartman · 2024-04-29T09:44:11Z

frontend/src/component/common/Badge/Badge.tsx

+const StyledBadgeIcon = styled('span')<
+    IBadgeIconProps & { hasChildren?: boolean }
+>(({ theme, color = 'neutral', iconRight = false, hasChildren }) => ({
+    display: 'flex',
+    color:
+        color === 'disabled'
+            ? theme.palette.action.disabled
+            : theme.palette[color].main,
+    margin: iconRight
+        ? theme.spacing(0, 0, 0, hasChildren ? 0.5 : 0)
+        : theme.spacing(0, hasChildren ? 0.5 : 0, 0, 0),
+}));

-const BadgeIcon = (color: Color, icon: ReactElement, iconRight = false) => (
-    <StyledBadgeIcon color={color} iconRight={iconRight}>
+const BadgeIcon = (
+    color: Color,
+    icon: ReactElement,
+    iconRight = false,
+    hasChildren = false,
+) => (
+    <StyledBadgeIcon
+        color={color}
+        iconRight={iconRight}
+        hasChildren={hasChildren}
+    >


could be refactored to using flexbox/grid and the gap property

thomasheartman · 2024-04-29T09:45:05Z

Remember to handle projects with 0 member that aren't the default project.

github-actions bot assigned Tymek Apr 26, 2024

codescene-delta-analysis bot approved these changes Apr 26, 2024

View reviewed changes

frontend/src/component/project/ProjectList/ProjectList.tsx Show resolved Hide resolved

codescene-delta-analysis bot approved these changes Apr 26, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-docs April 26, 2024 10:19 View deployment

vercel bot deployed to Preview – unleash-monorepo-frontend April 26, 2024 10:20 View deployment

codescene-delta-analysis bot approved these changes Apr 26, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 26, 2024 11:31 View deployment

codescene-delta-analysis bot approved these changes Apr 26, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 26, 2024 11:32 View deployment

Tymek added 8 commits April 26, 2024 13:33

project owners api draft

9bbbb4a

single user project owner description

712b266

styled project owners footer

ca22dc4

new project icon

ceebca1

project mode badge

f8fb8b0

project owner for default project

18f819f

system avatar

831092d

combine with backend

19660d2

Tymek force-pushed the feat/project-owners branch from e78cee6 to 19660d2 Compare April 26, 2024 11:33

codescene-delta-analysis bot approved these changes Apr 26, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 26, 2024 11:34 View deployment

Tymek added 2 commits April 26, 2024 13:50

Merge remote-tracking branch 'origin/main' into feat/project-owners

adebdb9

refactor: project card padding

3a84636

codescene-delta-analysis bot approved these changes Apr 26, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 26, 2024 11:57 View deployment

refactor: projects list spacing

83957ea

codescene-delta-analysis bot approved these changes Apr 26, 2024

View reviewed changes

fix: remove duplicate flag

408f51a

codescene-delta-analysis bot approved these changes Apr 26, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 26, 2024 12:09 View deployment

vercel bot deployed to Preview – unleash-monorepo-frontend April 26, 2024 12:20 View deployment

Tymek marked this pull request as ready for review April 26, 2024 12:24

Tymek requested review from FredrikOseberg and thomasheartman April 26, 2024 12:24

refactor: project owners if-else

a08b353

Tymek changed the title ~~Feat/project owners~~ feat: Project owners UI Apr 26, 2024

codescene-delta-analysis bot approved these changes Apr 26, 2024

View reviewed changes

Tymek commented Apr 26, 2024

View reviewed changes

src/lib/features/project/project-owners-read-model.ts Show resolved Hide resolved

vercel bot deployed to Preview – unleash-monorepo-frontend April 26, 2024 12:26 View deployment

thomasheartman reviewed Apr 26, 2024

View reviewed changes

refactor: cleanup

2e14feb

codescene-delta-analysis bot approved these changes Apr 26, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 26, 2024 12:58 View deployment

fix: read undefined

7dd62bb

Tymek marked this pull request as draft April 26, 2024 12:59

codescene-delta-analysis bot approved these changes Apr 26, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 26, 2024 12:59 View deployment

thomasheartman reviewed Apr 29, 2024

View reviewed changes

Update frontend/src/component/project/NewProjectCard/NewProjectCard.tsx

3a0f94f

Co-authored-by: Thomas Heartman <thomas@getunleash.io>

thomasheartman approved these changes Apr 29, 2024

View reviewed changes

Tymek and others added 2 commits April 29, 2024 11:40

Update frontend/src/component/project/ProjectList/ProjectGroup.tsx

4b8aea8

Co-authored-by: Thomas Heartman <thomas@getunleash.io>

Update frontend/src/component/project/ProjectList/ProjectGroup.tsx

24ec96e

Co-authored-by: Thomas Heartman <thomas@getunleash.io>

codescene-delta-analysis bot approved these changes Apr 29, 2024

View reviewed changes

vercel bot deployed to Preview – unleash-monorepo-frontend April 29, 2024 09:43 View deployment

thomasheartman reviewed Apr 29, 2024

View reviewed changes

Tymek marked this pull request as ready for review April 29, 2024 09:44

Tymek merged commit b6865a5 into main Apr 29, 2024
13 of 14 checks passed

Tymek deleted the feat/project-owners branch April 29, 2024 09:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Project owners UI #6949

feat: Project owners UI #6949

Tymek commented Apr 26, 2024 •

edited

Loading

vercel bot commented Apr 26, 2024 •

edited

Loading

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

thomasheartman left a comment

thomasheartman Apr 26, 2024

thomasheartman Apr 26, 2024

thomasheartman Apr 26, 2024

thomasheartman Apr 26, 2024

thomasheartman Apr 26, 2024

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

thomasheartman Apr 29, 2024

thomasheartman Apr 29, 2024

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

thomasheartman Apr 29, 2024

thomasheartman commented Apr 29, 2024

feat: Project owners UI #6949

feat: Project owners UI #6949

Conversation

Tymek commented Apr 26, 2024 • edited Loading

vercel bot commented Apr 26, 2024 • edited Loading

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

thomasheartman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thomasheartman commented Apr 29, 2024

Tymek commented Apr 26, 2024 •

edited

Loading

vercel bot commented Apr 26, 2024 •

edited

Loading