Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check production enabled live stage #6952

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Apr 26, 2024

About the changes

To enter the live stage we need to check if feature env is enabled

Important files

Discussion points

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 11:30am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 11:30am

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Comment on lines +18 to +27
const {
featureLifecycleService,
eventStore,
environmentStore,
featureEnvironmentStore,
} = createFakeFeatureLifecycleService({
flagResolver: { isEnabled: () => true },
eventBus,
getLogger: noLoggerProvider,
} as unknown as IUnleashConfig);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ New issue: Large Method
'can insert and read lifecycle stages' has 77 lines, threshold = 70

Suppress

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

@kwasniew kwasniew merged commit 49e84d3 into main Apr 26, 2024
7 checks passed
@kwasniew kwasniew deleted the check-production-enabled-live-stage branch April 26, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant