[Gitar] Cleaning up stale feature flag: applicationOverviewNewQuery with value true #6956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
gitar-bot
bot
force-pushed
the
gitar_gitar__applicationOverviewNewQuery_true
branch
from
927e0a4
to
a46ddf5
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
-403
to
-405
| if (!this.flagResolver.isEnabled('applicationOverviewNewQuery')) { | ||
| return this.mapOldApplicationOverviewData(rows, existingStrategies); | ||
| } |
There was a problem hiding this comment.
✅ Getting better: Complex Method
ClientApplicationsStore.mapApplicationOverviewData decreases in cyclomatic complexity from 15 to 14, threshold = 9
Comment on lines
-489
to
-572
| private mapOldApplicationOverviewData( | ||
| rows: any[], | ||
| existingStrategies: string[], | ||
| ): IApplicationOverview { | ||
| const featureCount = new Set(rows.map((row) => row.feature_name)).size; | ||
| const missingStrategies: Set<string> = new Set(); | ||
|
|
||
| const environments = rows.reduce((acc, row) => { | ||
| const { | ||
| environment, | ||
| instance_id, | ||
| sdk_version, | ||
| last_seen, | ||
| project, | ||
| feature_name, | ||
| strategies, | ||
| } = row; | ||
|
|
||
| if (!environment) return acc; | ||
|
|
||
| strategies.forEach((strategy) => { | ||
| if ( | ||
| !DEPRECATED_STRATEGIES.includes(strategy) && | ||
| !existingStrategies.includes(strategy) | ||
| ) { | ||
| missingStrategies.add(strategy); | ||
| } | ||
| }); | ||
|
|
||
| const featureDoesNotExist = !project && feature_name; | ||
|
|
||
| let env = acc.find((e) => e.name === environment); | ||
| if (!env) { | ||
| env = { | ||
| name: environment, | ||
| instanceCount: instance_id ? 1 : 0, | ||
| sdks: sdk_version ? [sdk_version] : [], | ||
| lastSeen: last_seen, | ||
| uniqueInstanceIds: new Set( | ||
| instance_id ? [instance_id] : [], | ||
| ), | ||
| issues: { | ||
| missingFeatures: featureDoesNotExist | ||
| ? [feature_name] | ||
| : [], | ||
| }, | ||
| }; | ||
| acc.push(env); | ||
| } else { | ||
| if (instance_id) { | ||
| env.uniqueInstanceIds.add(instance_id); | ||
| env.instanceCount = env.uniqueInstanceIds.size; | ||
| } | ||
| if ( | ||
| featureDoesNotExist && | ||
| !env.issues.missingFeatures.includes(feature_name) | ||
| ) { | ||
| env.issues.missingFeatures.push(feature_name); | ||
| } | ||
| if (sdk_version && !env.sdks.includes(sdk_version)) { | ||
| env.sdks.push(sdk_version); | ||
| } | ||
| if (new Date(last_seen) > new Date(env.lastSeen)) { | ||
| env.lastSeen = last_seen; | ||
| } | ||
| } | ||
|
|
||
| return acc; | ||
| }, []); | ||
| environments.forEach((env) => { | ||
| delete env.uniqueInstanceIds; | ||
| env.sdks.sort(); | ||
| }); | ||
|
|
||
| return { | ||
| projects: [ | ||
| ...new Set( | ||
| rows | ||
| .filter((row) => row.project != null) | ||
| .map((row) => row.project), | ||
| ), | ||
| ], | ||
| featureCount, | ||
| environments, |
There was a problem hiding this comment.
✅ No longer an issue: Complex Method
ClientApplicationsStore.mapOldApplicationOverviewData is no longer above the threshold for cyclomatic complexity
| @@ -301,9 +301,6 @@ export default class ClientApplicationsStore | |||
| async getApplicationOverview( | |||
| appName: string, | |||
| ): Promise<IApplicationOverview> { | |||
| if (!this.flagResolver.isEnabled('applicationOverviewNewQuery')) { | |||
There was a problem hiding this comment.
✅ No longer an issue: String Heavy Function Arguments
The ratio of strings in function arguments is no longer above the threshold
sjaanus
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Flag Cleanup
Trigger
#6559 (comment)
Bot Commands
@gitar-bot cleanup stale_flag=valuewill cleanup a stale feature flag. Replacestale_flagwith the name of the stale feature flag andvaluewith eithertrueorfalse.